[webkit-reviews] review granted: [Bug 184555] [Web Animations] Fix a host of small CSS Animations and CSS Transitions issues : [Attachment 337831] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 12 13:50:09 PDT 2018
Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 184555: [Web Animations] Fix a host of small CSS Animations and CSS
Transitions issues
https://bugs.webkit.org/show_bug.cgi?id=184555
Attachment 337831: Patch
https://bugs.webkit.org/attachment.cgi?id=337831&action=review
--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 337831
--> https://bugs.webkit.org/attachment.cgi?id=337831
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=337831&action=review
> Source/WebCore/animation/CSSAnimation.cpp:34
> +Ref<CSSAnimation> CSSAnimation::create(Element& target, const Animation&
backingAnimation, const RenderStyle* oldStyle, const RenderStyle& newStyle)
Why is one a pointer? Can oldStyle be null?
More information about the webkit-reviews
mailing list