[webkit-reviews] review granted: [Bug 184543] [iOS] AirPlay device name is sometimes wrong : [Attachment 337814] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 11:45:32 PDT 2018


Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 184543: [iOS] AirPlay device name is sometimes wrong
https://bugs.webkit.org/show_bug.cgi?id=184543

Attachment 337814: Patch

https://bugs.webkit.org/attachment.cgi?id=337814&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 337814
  --> https://bugs.webkit.org/attachment.cgi?id=337814
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337814&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:2791
> +    if ([getAVOutputContextClass()
respondsToSelector:@selector(sharedAudioPresentationOutputContext)]) {

Nit: should this be below the AVFoundationLibrary() check below?


More information about the webkit-reviews mailing list