[webkit-reviews] review granted: [Bug 184507] pemfile.py should not assume POSIX line endings : [Attachment 337712] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 12 11:27:47 PDT 2018
Daniel Bates <dbates at webkit.org> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 184507: pemfile.py should not assume POSIX line endings
https://bugs.webkit.org/show_bug.cgi?id=184507
Attachment 337712: Patch
https://bugs.webkit.org/attachment.cgi?id=337712&action=review
--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 337712
--> https://bugs.webkit.org/attachment.cgi?id=337712
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=337712&action=review
r=me
> Tools/Scripts/webkitpy/common/system/pemfile.py:101
> + lines = re.split('\r?\n', content)
Could the PEM file ever contain only carriage returns (\r)?
More information about the webkit-reviews
mailing list