[webkit-reviews] review granted: [Bug 184541] [Web Animations] Suspend animations when required : [Attachment 337800] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 12 09:40:10 PDT 2018
Jon Lee <jonlee at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 184541: [Web Animations] Suspend animations when required
https://bugs.webkit.org/show_bug.cgi?id=184541
Attachment 337800: Patch
https://bugs.webkit.org/attachment.cgi?id=337800&action=review
--- Comment #2 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 337800
--> https://bugs.webkit.org/attachment.cgi?id=337800
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=337800&action=review
> Source/WebCore/ChangeLog:19
> + (WebCore::DocumentTimeline::numberOfActiveAnimations const): Called
by Internals::numberOfActiveAnimations(), this
I think we tend to name functions specific for internals with the "ForTesting"
suffix. so: numberOfActiveAnimationsForTesting; to prevent accidental use by
real code.
More information about the webkit-reviews
mailing list