[webkit-reviews] review denied: [Bug 184534] [WPE] Fix --display-server=weston to spawn the server : [Attachment 337790] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 12 06:07:14 PDT 2018


Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Xabier Rodríguez
Calvar <calvaris at igalia.com>'s request for review:
Bug 184534: [WPE] Fix --display-server=weston to spawn the server
https://bugs.webkit.org/show_bug.cgi?id=184534

Attachment 337790: Patch

https://bugs.webkit.org/attachment.cgi?id=337790&action=review




--- Comment #2 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 337790
  --> https://bugs.webkit.org/attachment.cgi?id=337790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337790&action=review

> Tools/Scripts/webkitpy/port/wpe.py:73
> -	   return WaylandDriver
> +	   if self._display_server == "weston":
> +	       return WestonDriver
> +	   if self._display_server == "wayland":
> +	       return WaylandDriver

Please keep the wayland driver as default (when no option is passed)


More information about the webkit-reviews mailing list