[webkit-reviews] review granted: [Bug 184513] [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors : [Attachment 337721] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 11 14:58:38 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 184513: [WPE] Make WebKitWebViewBackend object mandatory for
webkit_web_view_new*() constructors
https://bugs.webkit.org/show_bug.cgi?id=184513

Attachment 337721: Patch

https://bugs.webkit.org/attachment.cgi?id=337721&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 337721
  --> https://bugs.webkit.org/attachment.cgi?id=337721
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337721&action=review

> Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:149
> +	       auto* backend = wpe_view_backend_create();
> +	       return webkit_web_view_backend_new(backend,
reinterpret_cast<GDestroyNotify>(wpe_view_backend_destroy), backend);

I would write it in one line


More information about the webkit-reviews mailing list