[webkit-reviews] review canceled: [Bug 184467] Introduce remote variants of Frame / DOMWindow classes : [Attachment 337729] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 11 14:25:13 PDT 2018


Chris Dumez <cdumez at apple.com> has canceled Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 184467: Introduce remote variants of Frame / DOMWindow classes
https://bugs.webkit.org/show_bug.cgi?id=184467

Attachment 337729: Patch

https://bugs.webkit.org/attachment.cgi?id=337729&action=review




--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 337729
  --> https://bugs.webkit.org/attachment.cgi?id=337729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337729&action=review

>>>> Source/WebCore/ChangeLog:10
>>>> +	      are hosted on another WebProcess. Those will be used in a
follow-up patch.
>>> 
>>> Given what a fundamental change this is, I think this could use a more
fleshed out ChangeLog. Specifically, I like to see an overview of how these
remote variants will work, especially for things like the Frame/DOMWindow tree,
openers, etc.
>> 
>> Ok, I'll flesh out the changelog and upload the follow-up patch to a
separate bug so you can see how it is used.
> 
> Note that short-term I only plan to implement window.open() cross origin, not
out of process iframes. This makes things a bit simpler as only a top-level
window/frame can be remote for now.

I uploaded a more complete patch at
https://bugs.webkit.org/show_bug.cgi?id=184515 where this code is used.
Feedback is most welcome.


More information about the webkit-reviews mailing list