[webkit-reviews] review denied: [Bug 184507] pemfile.py should not assume POSIX line endings : [Attachment 337709] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 11 10:22:23 PDT 2018


Daniel Bates <dbates at webkit.org> has denied Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 184507: pemfile.py should not assume POSIX line endings
https://bugs.webkit.org/show_bug.cgi?id=184507

Attachment 337709: Patch

https://bugs.webkit.org/attachment.cgi?id=337709&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 337709
  --> https://bugs.webkit.org/attachment.cgi?id=337709
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337709&action=review

> Tools/Scripts/webkitpy/common/system/pemfile.py:101
> +    lines = re.split("\r?\n", content)

Please add a unit test for this change.


More information about the webkit-reviews mailing list