[webkit-reviews] review granted: [Bug 184478] Use more r-values in NetworkResourceLoader : [Attachment 337662] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 184478: Use more r-values in NetworkResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=184478

Attachment 337662: Patch

https://bugs.webkit.org/attachment.cgi?id=337662&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 337662
  --> https://bugs.webkit.org/attachment.cgi?id=337662
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337662&action=review

r=me with comment.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:178
> +    m_cache->retrieve(request, { m_parameters.webPageID,
m_parameters.webFrameID }, [this, loader = WTFMove(loader), request =
ResourceRequest { request }](auto entry) mutable {

This was already capturing by value, I do not understand why the explicit "=
ResourceRequest { request }" would be needed.