[webkit-reviews] review denied: [Bug 184357] [WPE] Switch testing process to using WPEBackend-fdo : [Attachment 337685] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied  review:
Bug 184357: [WPE] Switch testing process to using WPEBackend-fdo
https://bugs.webkit.org/show_bug.cgi?id=184357

Attachment 337685: Patch

https://bugs.webkit.org/attachment.cgi?id=337685&action=review




--- Comment #14 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 337685
  --> https://bugs.webkit.org/attachment.cgi?id=337685
Patch

I believe this breaks all the WebKitWebView constructors, which guarantee that
a default backend is used when passed NULL for the WebKitWebViewBackend
parameter. Correct?

So we need to change all five of the WebKitWebView constructors. For example,
we would change:

 * webkit_web_view_new_with_related_view: (constructor)
 * @backend: (nullable) (transfer full): a #WebKitWebViewBackend, or %NULL to
use the default
 * @web_view: the related #WebKitWebView

to:

 * webkit_web_view_new_with_related_view: (constructor)
 * @backend: (transfer full): a #WebKitWebViewBackend
 * @web_view: the related #WebKitWebView

dropping the (nullable), and then add a corresponding g_return_val_if_fail:

    g_return_val_if_fail(WEBKIT_IS_WEB_VIEW_BACKEND(backend, nullptr);
    g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), nullptr);