[webkit-reviews] review granted: [Bug 184357] [WPE] Switch testing process to using WPEBackend-fdo : [Attachment 337685] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 184357: [WPE] Switch testing process to using WPEBackend-fdo
https://bugs.webkit.org/show_bug.cgi?id=184357

Attachment 337685: Patch

https://bugs.webkit.org/attachment.cgi?id=337685&action=review




--- Comment #13 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 337685
  --> https://bugs.webkit.org/attachment.cgi?id=337685
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337685&action=review

both dyz and layout-tests work fine for me now and the patch is fine, so r+

> Tools/Scripts/webkitpy/port/wpe.py:69
> -	   if self._display_server == "wayland":
> -	       return WaylandDriver
> -	   return HeadlessDriver
> +	   return WaylandDriver

I think we need to implement some function like gtk.py:check_sys_deps() so it
aborts early if no wayland env is detected, but we can do that in a another
patch
I also keep thinking the name is not the best, we are reusing the wayland
driver for a headless driver that runs inside a wayland env, but ok for now