[webkit-reviews] review granted: [Bug 155634] http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests are flaky : [Attachment 337641] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 15:39:30 PDT 2018


youenn fablet <youennf at gmail.com> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 155634:
http/tests/security/shape-image-cors-redirect-error-message-logging-*.html
tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=155634

Attachment 337641: Patch

https://bugs.webkit.org/attachment.cgi?id=337641&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 337641
  --> https://bugs.webkit.org/attachment.cgi?id=337641
Patch

Not sure there is a need for a r+ but anyway, here it is.

View in context: https://bugs.webkit.org/attachment.cgi?id=337641&action=review

>
LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging
-2-expected.txt:1
> +CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by
Access-Control-Allow-Origin.

Isn't this new message harder to understand by not providing the URL being
loaded?


More information about the webkit-reviews mailing list