[webkit-reviews] review granted: [Bug 175569] Add the PerformanceServerTiming Interface which makes Server-Timing header timing values available to JavaScript running in the browser. : [Attachment 337624] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted cvazac at gmail.com's request for
review:
Bug 175569: Add the PerformanceServerTiming Interface which makes Server-Timing
header timing values available to JavaScript running in the browser.
https://bugs.webkit.org/show_bug.cgi?id=175569

Attachment 337624: Patch

https://bugs.webkit.org/attachment.cgi?id=337624&action=review




--- Comment #51 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 337624
  --> https://bugs.webkit.org/attachment.cgi?id=337624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337624&action=review

> Source/WebCore/loader/ResourceTiming.h:30
> +#include "PerformanceServerTiming.h"

Can you try forward-declare PerformanceServerTiming?

> Source/WebCore/loader/ResourceTiming.h:62
> +    ResourceTiming(const URL& url, const String& initiator, const
LoadTiming& loadTiming, const NetworkLoadMetrics& networkLoadMetrics, bool
allowTimingDetails, Vector<ServerTiming>&& serverTiming)

If you can forward declare PerformanceServerTiming, could you also check
whether we can easily change this constructor to take r-values for each
meaningful field (provided it is used only/mainly for 
ResourceTiming::isolatedCopy).