[webkit-reviews] review granted: [Bug 184438] [Win] Add UserAgentWin.cpp : [Attachment 337586] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 184438: [Win] Add UserAgentWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=184438

Attachment 337586: Patch

https://bugs.webkit.org/attachment.cgi?id=337586&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 337586
  --> https://bugs.webkit.org/attachment.cgi?id=337586
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337586&action=review

> Source/WebCore/ChangeLog:8
> +	   No new tests (No behavior change).

It's definitely a behavior change, right? You have a user agent now where you
did not before.

> Source/WebCore/platform/win/UserAgentWin.cpp:55
> +    return String();

return { }