[webkit-reviews] review granted: [Bug 184418] ImageFrame type used by non-Cocoa image decoder should not be the same as that used by ImageSource : [Attachment 337504] patch

[bugzilla-daemon at webkit.org]

Said Abou-Hallawa <sabouhallawa at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 184418: ImageFrame type used by non-Cocoa image decoder should not be the
same as that used by ImageSource
https://bugs.webkit.org/show_bug.cgi?id=184418

Attachment 337504: patch

https://bugs.webkit.org/attachment.cgi?id=337504&action=review




--- Comment #18 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 337504
  --> https://bugs.webkit.org/attachment.cgi?id=337504
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337504&action=review

> Source/WebCore/platform/image-decoders/ScalableImageDecoderFrame.cpp:2
> + * Copyright (C) 2016 Apple Inc.  All rights reserved.

2018

> Source/WebCore/platform/image-decoders/ScalableImageDecoderFrame.cpp:-113
>  #if !USE(CG)
> -bool ImageFrame::initialize(const ImageBackingStore& backingStore)

Why we still have this #ifdef? This code will not compile for CG. right?

> Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp:389
> +	   ScalableImageDecoderFrame::DisposalMethod prevMethod =
prevBuffer->disposalMethod();

I think this can also be auto.

> Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:759
> +    ScalableImageDecoderFrame::DisposalMethod prevMethod =
prevBuffer->disposalMethod();

I thing this can also be auto.