[webkit-reviews] review granted: [Bug 184322] Add ProcessPrivilege assertions to places that access NSApp : [Attachment 337559] Patch (Rebased to current)

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 184322: Add ProcessPrivilege assertions to places that access NSApp
https://bugs.webkit.org/show_bug.cgi?id=184322

Attachment 337559: Patch (Rebased to current)

https://bugs.webkit.org/attachment.cgi?id=337559&action=review




--- Comment #7 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 337559
  --> https://bugs.webkit.org/attachment.cgi?id=337559
Patch (Rebased to current)

View in context: https://bugs.webkit.org/attachment.cgi?id=337559&action=review

R=me.

> Source/WebCore/platform/mac/PasteboardMac.mm:678
> +   
RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowSe
rver));

I believe the method Pasteboard::setDragImage is still called from WebContent
process. I think we can move this assert into the if statement.