[webkit-reviews] review granted: [Bug 184433] Refactor Ignore HSTS code : [Attachment 337565] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 184433: Refactor Ignore HSTS code
https://bugs.webkit.org/show_bug.cgi?id=184433

Attachment 337565: Patch

https://bugs.webkit.org/attachment.cgi?id=337565&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 337565
  --> https://bugs.webkit.org/attachment.cgi?id=337565
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337565&action=review

> Source/WebCore/platform/network/mac/WebCoreURLResponse.mm:337
> +    return [request
respondsToSelector:@selector(_schemeWasUpgradedDueToDynamicHSTS)]
> +    && [request _schemeWasUpgradedDueToDynamicHSTS];

Should fix indentation of the second line, indent by 4 spaces.

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:189
> +    return [request
respondsToSelector:@selector(_schemeWasUpgradedDueToDynamicHSTS)]
> +    && [request _schemeWasUpgradedDueToDynamicHSTS];

Should fix indentation of the second line, indent by 4 spaces.

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:197
> +    if ([request respondsToSelector:@selector(_setIgnoreHSTS:)]) {
> +	   BOOL ignoreHSTSParameter = ignoreHSTS;
> +	   [request _setIgnoreHSTS:ignoreHSTSParameter];
> +    }

This local BOOL is not needed here. It *was* needed for wtfObjcMsgSend, but
here you can just pass the bool ignoreHSTS and it will be converted to a BOOL.
Thus no braces needed either.

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:203
> +    return [request respondsToSelector:@selector(_ignoreHSTS)]
> +    && [request _ignoreHSTS];

Should fix indentation of the second line, indent by 4 spaces.