[webkit-reviews] review granted: [Bug 184344] WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll is directly accessing NSScreen : [Attachment 337535] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 184344: WebCore::EventHandler::targetPositionInWindowForSelectionAutoscroll
is directly accessing NSScreen
https://bugs.webkit.org/show_bug.cgi?id=184344

Attachment 337535: Patch

https://bugs.webkit.org/attachment.cgi?id=337535&action=review




--- Comment #17 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 337535
  --> https://bugs.webkit.org/attachment.cgi?id=337535
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337535&action=review

Very nice! r=me.

> Source/WebKit/WebProcess/WebProcess.cpp:138
> +#if PLATFORM(MAC)
> +#include <WebCore/PlatformScreen.h>
> +#endif

This include might not be needed.