[webkit-reviews] review granted: [Bug 184426] Add support for setting a background color on WKWebView and WKView : [Attachment 337543] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 184426: Add support for setting a background color on WKWebView and WKView
https://bugs.webkit.org/show_bug.cgi?id=184426

Attachment 337543: Patch

https://bugs.webkit.org/attachment.cgi?id=337543&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 337543
  --> https://bugs.webkit.org/attachment.cgi?id=337543
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337543&action=review

LGTM! You might need a WK2 owner to review, though.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:263
> + at property (nonatomic, setter=_setBackgroundColor:) NSColor
*_backgroundColor;

Nit - we usually make copyable non-POD properties copy.