[webkit-reviews] review granted: [Bug 184386] Block JavaScript scripts with banned MIME type : [Attachment 337523] Patch and layout tests

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 184386: Block JavaScript scripts with banned MIME type
https://bugs.webkit.org/show_bug.cgi?id=184386

Attachment 337523: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=337523&action=review




--- Comment #24 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 337523
  --> https://bugs.webkit.org/attachment.cgi?id=337523
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=337523&action=review

> Source/WebCore/dom/LoadableClassicScript.cpp:99
> +    if (!m_error &&
shouldResponseToRequestDestinationBeBlockedDueToMIMEType(m_cachedScript->respon
se(), m_cachedScript->options().destination)) {

This name is hard to digest.

I'd suggest something shorter and less specific.

The method is solely for script destinations and mime types *right now* but I
don't think we need to make sure the name makes that so explicitly clear.

I would actually be perfectly happy with "shouldBlockResponse()"