[webkit-reviews] review granted: [Bug 184423] Fix the selection assistant selectionView build : [Attachment 337516] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 9 12:07:37 PDT 2018
Wenson Hsieh <wenson_hsieh at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 184423: Fix the selection assistant selectionView build
https://bugs.webkit.org/show_bug.cgi?id=184423
Attachment 337516: Patch
https://bugs.webkit.org/attachment.cgi?id=337516&action=review
--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 337516
--> https://bugs.webkit.org/attachment.cgi?id=337516
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=337516&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4498
> [[_webSelectionAssistant selectionView] setHidden:NO];
You might want to consider guarding the declaration of the selectionView
property in UIKitSPI.h with ENABLE(MINIMAL_SIMULATOR) as well.
More information about the webkit-reviews
mailing list