[webkit-reviews] review granted: [Bug 183961] Use special software encoder mode in case there is no VCP nor hardware encoder : [Attachment 336444] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 183961: Use special software encoder mode in case there is no VCP nor
hardware encoder
https://bugs.webkit.org/show_bug.cgi?id=183961

Attachment 336444: Patch

https://bugs.webkit.org/attachment.cgi?id=336444&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 336444
  --> https://bugs.webkit.org/attachment.cgi?id=336444
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336444&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:674
> +    CFTypeRef values[attributesSize] = {kCFBooleanTrue, ioSurfaceValue,
pixelFormat};

Nit: declaring this immediately after "keys", and using the same
one-line-per-value style, would make it easier to understand.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:678
> +	 ioSurfaceValue = nullptr;

Nit: this is never accessed again so clearing it isn't necessary.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:682
> +	 pixelFormat = nullptr;

Ditto.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:685
> +    CFMutableDictionaryRef encoder_specs = CFDictionaryCreateMutable(

Nit: you use camel case for the other local variables so this should probably
as well.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:686
> +	   nullptr, 2, &kCFTypeDictionaryKeyCallBacks,
&kCFTypeDictionaryValueCallBacks);

Nit: I don't think the line break makes this more readable.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:693
> +	   usage = nullptr;

Nit: ditto the comment above about clearing.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:711
> +	 sourceAttributes = nullptr;

Ditto.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:715
> +	 encoder_specs = nullptr;

Ditto.