[webkit-reviews] review granted: [Bug 184395] Add pointer profiling to the FTL and supporting code. : [Attachment 337454] proposed patch.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 184395: Add pointer profiling to the FTL and supporting code.
https://bugs.webkit.org/show_bug.cgi?id=184395

Attachment 337454: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=337454&action=review




--- Comment #5 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 337454
  --> https://bugs.webkit.org/attachment.cgi?id=337454
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=337454&action=review

> Source/JavaScriptCore/ftl/FTLOutput.h:408
> -    LValue operation(FunctionType function) { return
constIntPtr(bitwise_cast<void*>(function)); }
> +    LValue operation(FunctionType function) { return
constIntPtr(tagCFunctionPtr<void*>(function, B3CCallPtrTag)); }

Ideally we would support passing more specific diversity to B3::CCall.	Can you
file a bug and reference it here with a FIXME?

I totally see how it's not necessary for making this feature work right now,
but such a FIXME will help us remember that it's only this way because it was
expedient.