[webkit-reviews] review denied: [Bug 184382] REGRESSION(r229929): localStorage is broken for WebInspector : [Attachment 337453] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 184382: REGRESSION(r229929): localStorage is broken for WebInspector
https://bugs.webkit.org/show_bug.cgi?id=184382

Attachment 337453: Patch

https://bugs.webkit.org/attachment.cgi?id=337453&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 337453
  --> https://bugs.webkit.org/attachment.cgi?id=337453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337453&action=review

> Source/WebCore/platform/sql/SQLiteStatement.cpp:388
> +	   if (!(error == SQLITE_OK || error == SQLITE_ROW || error ==
SQLITE_DONE))

As per the doc, "If the most recent API call was successful, then the return
value from sqlite3_errcode() is undefined." Therefore, I do not think this
patch is correct.