[webkit-reviews] review granted: [Bug 184414] WKTR: Enable DOM cache, SW registration directory cleanup on non-Cocoa platforms : [Attachment 337487] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 9 08:17:22 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 184414: WKTR: Enable DOM cache, SW registration directory cleanup on
non-Cocoa platforms
https://bugs.webkit.org/show_bug.cgi?id=184414

Attachment 337487: Patch

https://bugs.webkit.org/attachment.cgi?id=337487&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 337487
  --> https://bugs.webkit.org/attachment.cgi?id=337487
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337487&action=review

> Tools/WebKitTestRunner/TestController.cpp:2425
> +void TestController::getAllStorageAccessEntries()
> +{
> +}

I was about to say "you should keep the FIXME here," but I see from the context
of the surrounding methods that it is most definitely implied. Shame we have so
much unimplemented here.


More information about the webkit-reviews mailing list