[webkit-reviews] review granted: [Bug 182785] Start migration to a version of windowToContents() that may take scroll offset into account for delegated scrolling : [Attachment 334024] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 182785: Start migration to a version of windowToContents() that may take
scroll offset into account for delegated scrolling
https://bugs.webkit.org/show_bug.cgi?id=182785

Attachment 334024: Patch

https://bugs.webkit.org/attachment.cgi?id=334024&action=review




--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 334024
  --> https://bugs.webkit.org/attachment.cgi?id=334024
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334024&action=review

> Source/WebCore/platform/ScrollView.h:298
> -    WEBCORE_EXPORT IntPoint windowToContents(const IntPoint&) const;
> +    WEBCORE_EXPORT IntPoint deprecatedWindowToContents(const IntPoint&)
const;

This needs a comments saying why deprecatedWindowToContents() exists.

I think you should also add back windowToContents() without the
delegatesScrolling check in this or a followup commit.