[webkit-reviews] review granted: [Bug 183508] Use alignas instead of compiler-specific attributes : [Attachment 335419] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 183508: Use alignas instead of compiler-specific attributes
https://bugs.webkit.org/show_bug.cgi?id=183508

Attachment 335419: Patch

https://bugs.webkit.org/attachment.cgi?id=335419&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 335419
  --> https://bugs.webkit.org/attachment.cgi?id=335419
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335419&action=review

r=me

> Source/JavaScriptCore/jit/JIT.h:172
> +    // performance fluctuations. Try forcing alignment in an attempt to
stabalize this.

nit: /stabalize/stabilize/.  I know this came from an old comment, but might as
well fix it.

> Source/WTF/wtf/Gigacage.cpp:35
> +alignas(void*) char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE];

This disagrees with the bmalloc definition which has it as
alignas(GIGACAGE_BASE_PTRS_SIZE).  Unless you have a reason to not do so, let's
make it consistent with the bmalloc one.

> Source/WTF/wtf/Gigacage.h:37
> +alignas(void*) extern WTF_EXPORTDATA char
g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE];

Ditto.