[webkit-reviews] review granted: [Bug 184385] Have WorkerScriptLoader::loadAsynchronously() take a FetchOptions : [Attachment 337440] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 184385: Have WorkerScriptLoader::loadAsynchronously() take a FetchOptions
https://bugs.webkit.org/show_bug.cgi?id=184385

Attachment 337440: Patch

https://bugs.webkit.org/attachment.cgi?id=337440&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 337440
  --> https://bugs.webkit.org/attachment.cgi?id=337440
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337440&action=review

> Source/WebCore/loader/ThreadableLoader.h:66
> +	   ThreadableLoaderOptions(const FetchOptions&);

We could use explicit here.
In theory we should probably take a FetchOptions&& in case we set integrity in
the future for instance.

> Source/WebCore/workers/WorkerScriptLoader.cpp:96
> +    // service worker mode as an argument.

I don't really understand this comment.
The service worker spec states to set the service worker mode to none in case
of a service worker job.
And a service worker job could be executed from a worker/service worker
context.