[webkit-reviews] review granted: [Bug 184373] MediaSessionManageriOS should defer creation of MPVolumeView until it needs to monitor AirPlay routes : [Attachment 337402] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 184373: MediaSessionManageriOS should defer creation of MPVolumeView until
it needs to monitor AirPlay routes
https://bugs.webkit.org/show_bug.cgi?id=184373

Attachment 337402: Patch

https://bugs.webkit.org/attachment.cgi?id=337402&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 337402
  --> https://bugs.webkit.org/attachment.cgi?id=337402
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337402&action=review

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:429
> +		       BEGIN_BLOCK_OBJC_EXCEPTIONS
> +		       [routingController
setDiscoveryMode:MPRouteDiscoveryModeDisabled];
> +		       volumeView.clear();
> +		       routingController.clear();
> +		       END_BLOCK_OBJC_EXCEPTIONS

This is the same as the block in -dealloc, can they be shared?