[webkit-reviews] review granted: [Bug 184342] bmalloc virtual allocation API should not treat memory it vends as dirty with respect to how it drives the scavenger : [Attachment 337323] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 184342: bmalloc virtual allocation API should not treat memory it vends as
dirty with respect to how it drives the scavenger
https://bugs.webkit.org/show_bug.cgi?id=184342

Attachment 337323: patch

https://bugs.webkit.org/attachment.cgi?id=337323&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 337323
  --> https://bugs.webkit.org/attachment.cgi?id=337323
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337323&action=review

r=me

> Source/bmalloc/ChangeLog:13
> +	   we vend as dirty, versus what we do now, which is treat is all as
dirty.

typo: /treat is all/treat it all/.

> Source/bmalloc/ChangeLog:15
> +	   scavenger think its under memory pressure because memory it can't
free isn't

/because memory/because of memory/.