[webkit-reviews] review granted: [Bug 183247] Implement createImageBitmap(Blob) : [Attachment 335082] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 6 11:30:11 PDT 2018
Dean Jackson <dino at apple.com> has granted Ms2ger <Ms2ger at igalia.com>'s request
for review:
Bug 183247: Implement createImageBitmap(Blob)
https://bugs.webkit.org/show_bug.cgi?id=183247
Attachment 335082: Patch
https://bugs.webkit.org/attachment.cgi?id=335082&action=review
--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 335082
--> https://bugs.webkit.org/attachment.cgi?id=335082
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=335082&action=review
> Source/WebCore/html/ImageBitmap.cpp:592
> +void ImageBitmap::createFromBuffer(
> + Ref<ArrayBuffer>&& arrayBuffer,
> + String mimeType,
> + long long expectedContentLength,
> + const URL& sourceUrl,
> + ImageBitmapOptions&& options,
> + std::optional<IntRect> rect,
> + ImageBitmap::Promise&& promise)
We normally just put everything on a single line
More information about the webkit-reviews
mailing list