[webkit-reviews] review granted: [Bug 181597] ASSERTION FAILED: m_scriptExecutionContext under WebCore::AudioContext::isPlayingAudioDidChange() : [Attachment 337370] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 181597: ASSERTION FAILED: m_scriptExecutionContext under
WebCore::AudioContext::isPlayingAudioDidChange()
https://bugs.webkit.org/show_bug.cgi?id=181597

Attachment 337370: Patch

https://bugs.webkit.org/attachment.cgi?id=337370&action=review




--- Comment #18 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 337370
  --> https://bugs.webkit.org/attachment.cgi?id=337370
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337370&action=review

> Source/WebCore/Modules/webaudio/AudioContext.cpp:410
> +    if (isClosed())

ASSERT(isMainThread()) is sometimes but not always called for these calls.
We could remove a lot of these if we would add this assertion in
isClosed/isStopped/isInitialized.
It probably is not safe to check for isClosed/isStopped from a background
thread anyway.

> Source/WebCore/Modules/webaudio/AudioContext.h:275
> +    const Document* hostingDocument() const override;

final?

> Source/WebCore/Modules/webaudio/AudioContext.h:373
> +    std::unique_ptr<ThreadSafeGenericTaskQueue<CallOnMainThreadDispatcher>>
m_taskQueue;

Could be UniqueRef I guess since we are not nullify it.
Or maybe simply a ThreadSafeGenericTaskQueue<CallOnMainThreadDispatcher>?