[webkit-reviews] review granted: [Bug 184345] importScripts() should throw exception with a reason when it fails to load a script from the network : [Attachment 337368] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 184345: importScripts() should throw exception with a reason when it fails
to load a script from the network
https://bugs.webkit.org/show_bug.cgi?id=184345

Attachment 337368: Patch

https://bugs.webkit.org/attachment.cgi?id=337368&action=review




--- Comment #15 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 337368
  --> https://bugs.webkit.org/attachment.cgi?id=337368
Patch

> As far as I can tell ResourceErrorBase::m_localizedDescription is a misnomer.
It always represents a non-localized string. We should consider renaming it.

How did you come to this conclusion? On Mac at least, it's calling an SPI which
performs localization work.

However, there is a lot of precedent for using this particular ResourceError
function. I think that it is unfortunate that we are mixing localized platform
error strings with non-localized WebCore strings. As mentioned before, my
understanding is that we want both non-localized, but I don't really know.