[webkit-reviews] review denied: [Bug 184357] [WPE] Switch testing process to using WPEBackend-fdo : [Attachment 337359] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 184357: [WPE] Switch testing process to using WPEBackend-fdo
https://bugs.webkit.org/show_bug.cgi?id=184357

Attachment 337359: Patch

https://bugs.webkit.org/attachment.cgi?id=337359&action=review




--- Comment #7 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 337359
  --> https://bugs.webkit.org/attachment.cgi?id=337359
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337359&action=review

Setting r- because wpebackend-fdo still doesn't handle input and its not
possible to use a keyboard or a mouse with dyz, which is needed for testing.

>> Tools/Scripts/webkitpy/port/wpe.py:69
>> +	    return WaylandDriver
> 
> I find confusing that wayland driver is used unconditionally but the headless
backend is now used unconditionally too.

I also find this confusing.
I think the HeadlessDriver should inherit from WaylandDriver but keep its name
as headless.
And ideally the WaylandDriver would work also (if specified via command-line
argument), but the screen output will appear on the screen