[webkit-reviews] review denied: [Bug 184318] Process Swap on Navigation causes many webpages to hang : [Attachment 337231] Work in Progress Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied  review:
Bug 184318: Process Swap on Navigation causes many webpages to hang
https://bugs.webkit.org/show_bug.cgi?id=184318

Attachment 337231: Work in Progress Patch

https://bugs.webkit.org/attachment.cgi?id=337231&action=review




--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 337231
  --> https://bugs.webkit.org/attachment.cgi?id=337231
Work in Progress Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337231&action=review

I had fixed this locally, not knowing someone else was working on it.

My patch was simpler:

> Source/WebKit/UIProcess/WebPageProxy.cpp:2354
>	   if (action == PolicyAction::Use && navigation) {
> -	       auto proposedProcess =
process().processPool().processForNavigation(*this, *navigation, action);
> +	       auto proposedProcess =
process().processPool().processForNavigation(*this, *navigation, action,
frame.isMainFrame());

Instead of adding the new parameter, I just changed 2353 to:
-	 if (action == PolicyAction::Use && navigation) {
+	 if (action == PolicyAction::Use && navigation && frame.isMainFrame())
{