[webkit-reviews] review granted: [Bug 184326] WebContent process sometimes hangs in WebProcess::ensureNetworkProcessConnection : [Attachment 337255] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 13:22:48 PDT 2018


Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 184326: WebContent process sometimes hangs in
WebProcess::ensureNetworkProcessConnection
https://bugs.webkit.org/show_bug.cgi?id=184326

Attachment 337255: Patch

https://bugs.webkit.org/attachment.cgi?id=337255&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 337255
  --> https://bugs.webkit.org/attachment.cgi?id=337255
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337255&action=review

> Source/WebKit/Platform/IPC/Connection.h:340
> +    bool m_initializingSendSource { false };

I think we should use a prefix since this is a Boolean variable, I suggest:
m_isInitializingSendSource.


More information about the webkit-reviews mailing list