[webkit-reviews] review denied: [Bug 184306] REGRESSION (r230223): LayoutTest http/tests/contentextensions/css-display-none-overflows-rule-data-1.html is crashing : [Attachment 337190] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 4 21:16:07 PDT 2018


Ryosuke Niwa <rniwa at webkit.org> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 184306: REGRESSION (r230223): LayoutTest
http/tests/contentextensions/css-display-none-overflows-rule-data-1.html is
crashing
https://bugs.webkit.org/show_bug.cgi?id=184306

Attachment 337190: Patch

https://bugs.webkit.org/attachment.cgi?id=337190&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 337190
  --> https://bugs.webkit.org/attachment.cgi?id=337190
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337190&action=review

> Source/WebKit/NetworkProcess/NetworkContentRuleListManager.cpp:71
> +	   AtomicString::init();

NetworkProcess::initializeNetworkProcess already calls this. It makes no sense
that we have to initialize it again here.

> Source/WebKit/NetworkProcess/NetworkContentRuleListManager.cpp:72
> +	   WebCore::QualifiedName::init();

Qualified names!? Who is creating a qualified name in the network process?


More information about the webkit-reviews mailing list