[webkit-reviews] review granted: [Bug 184316] Add pointer profiling support to the DFG and supporting files. : [Attachment 337245] proposed patch.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted  review:
Bug 184316: Add pointer profiling support to the DFG and supporting files.
https://bugs.webkit.org/show_bug.cgi?id=184316

Attachment 337245: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=337245&action=review




--- Comment #5 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 337245
  --> https://bugs.webkit.org/attachment.cgi?id=337245
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=337245&action=review

OK, now that Mark explained this to me, I get it.  r=me

>> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:755
>> +#endif
> 
> Wait... won't this fail miserably if the OSR exit is reused at a different
stack height?

Never mind, this is the probe code.  It's right.