[webkit-reviews] review denied: [Bug 184268] REGRESSION(r227758): Webpage fails to load due to crash in com.apple.WebKit: WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse + 267 : [Attachment 337221] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 184268: REGRESSION(r227758): Webpage fails to load due to crash in
com.apple.WebKit: WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse
+ 267
https://bugs.webkit.org/show_bug.cgi?id=184268

Attachment 337221: Patch

https://bugs.webkit.org/attachment.cgi?id=337221&action=review




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 337221
  --> https://bugs.webkit.org/attachment.cgi?id=337221
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337221&action=review

r- due to the lack of description in the change log.

> Source/WebCore/ChangeLog:8
> +

Please add a description as to why the crash was happening, and how you fixed
it.

> Source/WebCore/ChangeLog:9
> +	   No new tests. An existing test is modified to not use injected
bundle policy so it can test the crash case.

You should name the test you've modified.

> LayoutTests/http/tests/multipart/multipart-html.php:-24
> -    $i++;

So we used to only generate 5 results?