[webkit-reviews] review granted: [Bug 183752] The layout test fast/canvas/canvas-blending-global-alpha.html is failing when the WebContent process does not have WindowServer access. : [Attachment 337201] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 183752: The layout test fast/canvas/canvas-blending-global-alpha.html is
failing when the WebContent process does not have WindowServer access.
https://bugs.webkit.org/show_bug.cgi?id=183752

Attachment 337201: Patch

https://bugs.webkit.org/attachment.cgi?id=337201&action=review




--- Comment #11 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 337201
  --> https://bugs.webkit.org/attachment.cgi?id=337201
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337201&action=review

r=me if this is working as I suggested in my comments.

> Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm:801
> +	   return m_displayMask.value();

Is this value already getting set on the WebProcess through a message pass from
the UIProcess? I think that was part of your OpenGL fix, right?

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:304
> +    uint32_t mask = GraphicsContext3D::getOpenGLDisplayMask();

if (uint32_t mask = GraphicsContext3D::getOpenGLDisplayMask())
    CGIOSurfaceContextSetDisplayMask(m_cgContext.get(), mask);