[webkit-reviews] review granted: [Bug 184257] [GTK] Add CMake package search for vpx and libevent libraries : [Attachment 337152] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 4 09:59:48 PDT 2018
Michael Catanzaro <mcatanzaro at igalia.com> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 184257: [GTK] Add CMake package search for vpx and libevent libraries
https://bugs.webkit.org/show_bug.cgi?id=184257
Attachment 337152: Patch
https://bugs.webkit.org/attachment.cgi?id=337152&action=review
--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 337152
--> https://bugs.webkit.org/attachment.cgi?id=337152
Patch
Can't you move the find modules, too?
What other ThirdParty modules have checks for their dependencies in
OptionsGTK.cmake? That shouldn't be. I don't see any.
More information about the webkit-reviews
mailing list