[webkit-reviews] review denied: [Bug 184289] Fix the print formatter build : [Attachment 337143] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 3 21:44:10 PDT 2018
mitz at webkit.org has denied Beth Dakin <bdakin at apple.com>'s request for review:
Bug 184289: Fix the print formatter build
https://bugs.webkit.org/show_bug.cgi?id=184289
Attachment 337143: Patch
https://bugs.webkit.org/attachment.cgi?id=337143&action=review
--- Comment #2 from mitz at webkit.org ---
Comment on attachment 337143
--> https://bugs.webkit.org/attachment.cgi?id=337143
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=337143&action=review
> Source/WebKit/UIProcess/_WKWebViewPrintFormatter.h:37
> +#if ENABLE(MINIMAL_SIMULATOR)
> +UIViewPrintFormatter
> +#else
We don’t use our internal ENABLE() macro in modern WebKit SPI headers.
> Source/WebKit/UIProcess/_WKWebViewPrintFormatter.h:41
> +#if !ENABLE(MINIMAL_SIMULATOR)
Ditto.
More information about the webkit-reviews
mailing list