[webkit-reviews] review granted: [Bug 184275] totalPhysicalSize calculation when splitting a range must account for double rounding effects : [Attachment 337100] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 184275: totalPhysicalSize calculation when splitting a range must account
for double rounding effects
https://bugs.webkit.org/show_bug.cgi?id=184275

Attachment 337100: patch

https://bugs.webkit.org/attachment.cgi?id=337100&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 337100
  --> https://bugs.webkit.org/attachment.cgi?id=337100
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337100&action=review

I see.	When you detect the rounding error, you re-attribute the error back
over to the left side.	r=me.

> Source/bmalloc/ChangeLog:10
> +	   rounding may cause the left size to loose a byte, and the right

typo: /loose/lose/.