[webkit-reviews] review granted: [Bug 184270] Make SessionStorage work with process swapping : [Attachment 337090] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 11:17:10 PDT 2018


Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 184270: Make SessionStorage work with process swapping
https://bugs.webkit.org/show_bug.cgi?id=184270

Attachment 337090: Patch

https://bugs.webkit.org/attachment.cgi?id=337090&action=review




--- Comment #4 from Andy Estes <aestes at apple.com> ---
Comment on attachment 337090
  --> https://bugs.webkit.org/attachment.cgi?id=337090
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337090&action=review

> Source/WebKit/ChangeLog:8
> +	   Do to a minor process accounting error, WebPageProxys weren't always
being reconnected with their

"do to"

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:634
> +    processPoolConfiguration.get().processSwapsOnNavigation = YES;

I think we prefer [processPoolConfiguration setProcessSwapsOnNavigation:YES]
(to avoid the ugly .get())

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:640
> +    RetainPtr<PSONScheme> handler1 = adoptNS([[PSONScheme alloc]
initWithBytes:sessionStorageTestBytes]);
> +    RetainPtr<PSONScheme> handler2 = adoptNS([[PSONScheme alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:644
> +    RetainPtr<PSONMessageHandler> messageHandler =
adoptNS([[PSONMessageHandler alloc] init]);

auto


More information about the webkit-reviews mailing list