[webkit-reviews] review denied: [Bug 184257] [GTK] Add CMake package search for vpx and libevent libraries : [Attachment 337072] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 184257: [GTK] Add CMake package search for vpx and libevent libraries
https://bugs.webkit.org/show_bug.cgi?id=184257

Attachment 337072: Patch

https://bugs.webkit.org/attachment.cgi?id=337072&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 337072
  --> https://bugs.webkit.org/attachment.cgi?id=337072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337072&action=review

But they're clearly only used by libwebrtc, so these don't belong outside
Source/ThirdParty/libwebrtc.

> Source/cmake/OptionsGTK.cmake:240
> +    find_package(Vpx 1.7.0)
> +    if (NOT LIBVPX_FOUND)
> +	  message(FATAL_ERROR "vpx is needed for USE_LIBWEBRTC.")
> +    endif ()
> +    find_package(LibEvent)
> +    if (NOT LIBEVENT_FOUND)
> +	  message(FATAL_ERROR "libevent is needed for USE_LIBWEBRTC.")
> +    endif ()

I think you want to do something like this, but in
Source/ThirdParty/libwebrtc/CMakeLists.txt instead.