[webkit-reviews] review granted: [Bug 184259] [SOUP] Stop using ResourceHandle to load GResources : [Attachment 337068] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 3 07:54:38 PDT 2018
Sergio Villar Senin <svillar at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 184259: [SOUP] Stop using ResourceHandle to load GResources
https://bugs.webkit.org/show_bug.cgi?id=184259
Attachment 337068: Patch
https://bugs.webkit.org/attachment.cgi?id=337068&action=review
--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 337068
--> https://bugs.webkit.org/attachment.cgi?id=337068
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=337068&action=review
> Source/WebCore/platform/glib/SharedBufferGlib.cpp:30
> +SharedBuffer::SharedBuffer(GBytes* bytes)
I guess this can be a reference since it cannot be null.
> Source/WebCore/platform/glib/SharedBufferGlib.cpp:37
> +Ref<SharedBuffer> SharedBuffer::create(GBytes* bytes)
Ditto.
More information about the webkit-reviews
mailing list