[webkit-reviews] review granted: [Bug 184216] Make SecurityOrigin safe to create and use from any thread : [Attachment 336951] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 184216: Make SecurityOrigin safe to create and use from any thread
https://bugs.webkit.org/show_bug.cgi?id=184216

Attachment 336951: Patch

https://bugs.webkit.org/attachment.cgi?id=336951&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 336951
  --> https://bugs.webkit.org/attachment.cgi?id=336951
Patch

I wonder whether we should not be making more SchemeRegistry thread safe.
All the methods only used by Document/DocumentLoader seem fine to me.
I am less sure of the Database one but probably it is and will remain safe?

Out of pure curiosity, it seems that we are really locking for write but maybe
we could allow multiple read in parallel?
Especially since we barely touch Schemes.

View in context: https://bugs.webkit.org/attachment.cgi?id=336951&action=review

> Source/WebCore/platform/SchemeRegistry.cpp:497
>  {

Ideally these registerXX should take a String&& since most of the time, they
are called from IPC that can provide String&&