[webkit-reviews] review denied: [Bug 184071] AX: Audit Tab should have an Audit Manager : [Attachment 336647] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Aaron Chu <aaron_chu at apple.com>'s
request for review:
Bug 184071: AX: Audit Tab should have an Audit Manager
https://bugs.webkit.org/show_bug.cgi?id=184071

Attachment 336647: Patch

https://bugs.webkit.org/attachment.cgi?id=336647&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 336647
  --> https://bugs.webkit.org/attachment.cgi?id=336647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336647&action=review

r-. I can't really review this because there are a lot of missing class
references, like WI.AuditTestCase, WI.AuditTestSuite, etc. These should all go
into the same patch.

The manager should not be firing events that are state changes of the model
object themselves (i.e., a suite or test case). As written this would be really
annoying to test because the event logic is all intertwined. The manager should
be keeping a list of reports, test cases, and suites; support creating a new
report from a suite; and provide other functionality like import/export.

> Source/WebInspectorUI/ChangeLog:23
> +2018-03-28  Aaron Chu  <aaron_chu at apple.com>

Nit: double ChangeLog.