[webkit-reviews] review granted: [Bug 184241] Define AVKit softlink macro : [Attachment 337014] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 184241: Define AVKit softlink macro
https://bugs.webkit.org/show_bug.cgi?id=184241

Attachment 337014: Patch

https://bugs.webkit.org/attachment.cgi?id=337014&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 337014
  --> https://bugs.webkit.org/attachment.cgi?id=337014
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337014&action=review

> Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:39
> +#if ENABLE(EXTRA_ZOOM_MODE)
> +#define SOFTLINK_AVKIT_FRAMEWORK()
SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL(AVKit)
> +#else
> +#define SOFTLINK_AVKIT_FRAMEWORK() SOFT_LINK_FRAMEWORK_OPTIONAL(AVKit)
> +#endif
> +

Nit: We should eventually move this into an "AVKitSoftLink.h" header and
matching source file.