[webkit-reviews] review granted: [Bug 183784] Non-Cocoa ports use default directory for ServiceWorker data during testing : [Attachment 337000] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 183784: Non-Cocoa ports use default directory for ServiceWorker data during
testing
https://bugs.webkit.org/show_bug.cgi?id=183784

Attachment 337000: Patch

https://bugs.webkit.org/attachment.cgi?id=337000&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 337000
  --> https://bugs.webkit.org/attachment.cgi?id=337000
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337000&action=review

> Tools/WebKitTestRunner/TestController.cpp:2400
> +	   WKWebsiteDataStoreSetServiceWorkerRegistrationDirectory(dataStore,
toWK(temporaryFolder + separator + "ServiceWorkerRegistration").get());

Cocoa uses "ServiceWorkers" as a folder name.
Not sure this is worth being consistent.